Move dir-index-html + assets to a separate repo #1487
Conversation
rht
force-pushed
the
gw-assets
branch
4 times, most recently
from
6e0e183
to
a331674
Compare
| `)) | ||
| var dirIndexPath = "vendor/src/QmeNXKecZ7CQagtkQUJxG3yS7UcvU6puS777dQsx3amkS7/dir-index-html/" | ||
| var dirIndex, _ = ioutil.ReadFile(dirIndexPath + "dir-index.html") | ||
| var listingTemplate = template.Must(template.New("dir").Funcs(template.FuncMap{"iconFromExt": iconFromExt}).Parse(string(dirIndex))) |
There was a problem hiding this comment.
a bit hard to read, maybe:
var listingTemplate = template.Must(template.New("dir").Funcs(template.FuncMap{
"iconFromExt": iconFromExt,
}).Parse(string(dirIndex)))
rht
force-pushed
the
gw-assets
branch
14 times, most recently
from
09692b3
to
886a534
Compare
| "hash": "QmeNXKecZ7CQagtkQUJxG3yS7UcvU6puS777dQsx3amkS7" | ||
| } | ||
| ] | ||
| } |
There was a problem hiding this comment.
cool! yay gx \o/
@whyrusleeping @rht this will "just work" for people without gx since it's checked into the vendor/ dir, right? (in the future we can see about not having to vendor in-repo (and just vendor via ipfs) once gx+ipfs proves ultra reliable + intuitive for users)
we could bite the bullet and abandon go get and have the makefile install gx and fetch the things for the user. what do we want here for now?
|
this LGTM! maybe rebase and good to merge? |
Yes, much like the generated code for protobuf. On Sun, Aug 2, 2015 at 7:57 PM, Juan Benet notifications@github.com wrote:
. |
|
@rht maybe rebase this on new master? |
License: MIT Signed-off-by: rht <rhtbot@gmail.com>
|
@jbenet rebased |
Move dir-index-html + assets to a separate repo
Move dir-index-html + assets to a separate repo This commit was moved from ipfs/kubo@1dac829
(Commited while the dir-index-html repo is still empty)